-
Notifications
You must be signed in to change notification settings - Fork 950
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: get_metadata deprecated since traitlets 4.1 #3894
fix: get_metadata deprecated since traitlets 4.1 #3894
Conversation
@ManonMarchand could you push this again please? I can try to help with CI failures, but the original logs aren't visible anymore. Arrived here after planning to submit an identical PR for vega/altair#3234 |
186e712
to
2d4f5b4
Compare
Sure, also rebased on main in case the ci failure wasn't due to the tiny fix |
@ManonMarchand looking at the last 4 merged commits, I don't think you should expect anything other than the last 4 tests passing I've tried using that auto binder link #3894 (comment) I think a maintainer will just need to merge as-is. There is also #3932 which seems to be passing CI, but is yet to be reviewed |
I will try a patch release very soon-ish with this and #3932, thanks @ManonMarchand ! |
2d4f5b4
to
a520a26
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Hello,
This is a very tiny PR, but I get a deprecation warning raised by this line from the traitlets library when using a custom ipywidget:
https://github.com/ipython/traitlets/blob/cb672eb5ba235fdfee6407bd7f1b1985de934e7c/traitlets/traitlets.py#L833
Here is a fix that should remove it?
Edit: I explicitly allow anyone to edit anything I might have done wrong, I have no idea why the tests are failing